[webkit-reviews] review granted: [Bug 213867] Crash in +[UIViewController _viewControllerForFullScreenPresentationFromView:] when WKContentView is deallocated : [Attachment 403374] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 2 11:26:51 PDT 2020


Darin Adler <darin at apple.com> has granted Austin <ablackwood at apple.com>'s
request for review:
Bug 213867: Crash in +[UIViewController
_viewControllerForFullScreenPresentationFromView:] when WKContentView is
deallocated
https://bugs.webkit.org/show_bug.cgi?id=213867

Attachment 403374: Patch

https://bugs.webkit.org/attachment.cgi?id=403374&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 403374
  --> https://bugs.webkit.org/attachment.cgi?id=403374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403374&action=review

> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:287
> +    RetainPtr<WKContentView> view = _view.get();
> +    if (view)

OK as is. But could write this:

    if (RetainPtr<WKContentView> view = _view.get())

or this:

    if (auto view = retainPtr(_view.get()))


More information about the webkit-reviews mailing list