[webkit-reviews] review denied: [Bug 213801] Added PannerNode constructor according to spec : [Attachment 403369] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Clark Wang <clark_wang at apple.com>'s
request for review:
Bug 213801: Added PannerNode constructor according to spec
https://bugs.webkit.org/show_bug.cgi?id=213801

Attachment 403369: Patch

https://bugs.webkit.org/attachment.cgi?id=403369&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 403369
  --> https://bugs.webkit.org/attachment.cgi?id=403369
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403369&action=review

>
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-pannerno
de-interface/ctor-panner-expected.txt:44
> +FAIL X new PannerNode(c, {"channelCount":0}) did not throw an exception.
assert_true: expected true got false

Looks like your constructor is not quite right. It seems you need to throw when
channelCount is not valid. I have verified that Firefox throws in this case.