[webkit-reviews] review denied: [Bug 213791] [GTK4] Support kinetic scrolling : [Attachment 403194] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 213791: [GTK4] Support kinetic scrolling
https://bugs.webkit.org/show_bug.cgi?id=213791

Attachment 403194: Patch

https://bugs.webkit.org/attachment.cgi?id=403194&action=review




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 403194
  --> https://bugs.webkit.org/attachment.cgi?id=403194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403194&action=review

Thanks! I think it would be easier to refactor the WebEventFactory create
functions.

> Source/WebKit/Shared/NativeWebWheelEvent.h:64
>      NativeWebWheelEvent(GdkEvent*, const WebCore::IntPoint&, const
WebCore::FloatSize& wheelTicks);
> +    NativeWebWheelEvent(GdkEvent*, const WebCore::IntPoint&, const
WebCore::FloatSize& wheelTicks, WebWheelEvent::Phase, WebWheelEvent::Phase
momentumPhase);

I think this new one makes the previous one unused, so better to modify the
existing one if needed.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1278
> +    WebWheelEvent::Phase phase = gdk_event_is_scroll_stop_event(event) ?
> +	   WebWheelEvent::Phase::PhaseEnded :
> +	   WebWheelEvent::Phase::PhaseChanged;

So, in the end we are passing a fixed momentum phase and phase value that
depends on event, so this could be done in WebEventFactory.cpp instead if the
parameters currently passed.