[webkit-reviews] review granted: [Bug 213864] Overlapping content on earny.co : [Attachment 403327] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 1 21:22:43 PDT 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 213864: Overlapping content on earny.co
https://bugs.webkit.org/show_bug.cgi?id=213864

Attachment 403327: Patch

https://bugs.webkit.org/attachment.cgi?id=403327&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 403327
  --> https://bugs.webkit.org/attachment.cgi?id=403327
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403327&action=review

> Source/WebCore/rendering/AutoTableLayout.cpp:75
> +		   columnLayout.minLogicalWidth =
std::max(columnLayout.minLogicalWidth, 0.f);
> +		   columnLayout.maxLogicalWidth =
std::max(columnLayout.maxLogicalWidth, 0.f);

I think we prefer std::max<float>()


More information about the webkit-reviews mailing list