[webkit-reviews] review granted: [Bug 213869] [JSC] Intl.Collator should set usage:"search" option through ICU locale : [Attachment 403339] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 213869: [JSC] Intl.Collator should set usage:"search" option through ICU
locale
https://bugs.webkit.org/show_bug.cgi?id=213869

Attachment 403339: Patch

https://bugs.webkit.org/attachment.cgi?id=403339&action=review




--- Comment #4 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 403339
  --> https://bugs.webkit.org/attachment.cgi?id=403339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403339&action=review

LGTM

> JSTests/stress/intl-collator-co-extension.js:6
> +function shouldBeArray(actual, expected) {

I should do this more often...I've used JSON.stringify too much in our Intl
tests, haha.