[webkit-reviews] review granted: [Bug 207067] Add KVO SPI WKWebView._negotiatedLegacyTLS : [Attachment 389413] patch with SPI documentation.

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 207067: Add KVO SPI WKWebView._negotiatedLegacyTLS
https://bugs.webkit.org/show_bug.cgi?id=207067

Attachment 389413: patch with SPI documentation.

https://bugs.webkit.org/attachment.cgi?id=389413&action=review




--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 389413
  --> https://bugs.webkit.org/attachment.cgi?id=389413
patch with SPI documentation.

View in context: https://bugs.webkit.org/attachment.cgi?id=389413&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:820
> +	   auto tlsVersion =
(tls_protocol_version_t)metrics.negotiatedTLSProtocolVersion.unsignedShortValue
;

reinterpret_cast?

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:821
> +	   if (tlsVersion == tls_protocol_version_TLSv10 || tlsVersion ==
tls_protocol_version_TLSv11)

`tlsVersion < tls_protocol_version_TLSv12`?

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:828
> +	       if (tlsVersion == kTLSProtocol11 || tlsVersion == kTLSProtocol1)

Ditto?

> Source/WebKit/UIProcess/PageLoadState.h:226
> +	   double estimatedProgress { 0.0 };

Our style is to just use 0 here.