[webkit-reviews] review granted: [Bug 207044] [Web Animations] [WK1] REGRESSION: opacity doesn't animate : [Attachment 389353] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 31 09:20:02 PST 2020
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 207044: [Web Animations] [WK1] REGRESSION: opacity doesn't animate
https://bugs.webkit.org/show_bug.cgi?id=207044
Attachment 389353: Patch
https://bugs.webkit.org/attachment.cgi?id=389353&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 389353
--> https://bugs.webkit.org/attachment.cgi?id=389353
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=389353&action=review
> Source/WebCore/animation/WebAnimation.cpp:1448
> + if (!isCompletelyAccelerated() || !isRunningAccelerated())
This would be clearers as hasAnyNonAcceleratedProperties or something, I think.
> LayoutTests/webanimations/opacity-animation.html:15
> + setTimeout(() => testRunner.notifyDone(), 100);
100ms is a really long test. Would setting the current time and pausing test
the same way? Why didn't requestAnimationFrame work?
More information about the webkit-reviews
mailing list