[webkit-reviews] review requested: [Bug 206984] REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges : [Attachment 389316] Patch v2

[bugzilla-daemon at webkit.org]

David Quesada <david_quesada at apple.com> has asked  for review:
Bug 206984: REGRESSION(r252185): NetworkSessionCocoa cancels downloads that
receive authentication challenges
https://bugs.webkit.org/show_bug.cgi?id=206984

Attachment 389316: Patch v2

https://bugs.webkit.org/attachment.cgi?id=389316&action=review




--- Comment #4 from David Quesada <david_quesada at apple.com> ---
Created attachment 389316

  --> https://bugs.webkit.org/attachment.cgi?id=389316&action=review

Patch v2

- Took Youenn's suggestion to zero-check the download ID before looking it up
in the DownloadMap.
- Added an API test that resumes a download and ensures the delegate can handle
the authentication challenge and the download can succeed.