[webkit-reviews] review denied: [Bug 207004] [CMake] Add _PRIVATE_LIBRARIES to framework : [Attachment 389266] Patch

[bugzilla-daemon at webkit.org]

Konstantin Tokarev <annulen at yandex.ru> has denied  review:
Bug 207004: [CMake] Add _PRIVATE_LIBRARIES to framework
https://bugs.webkit.org/show_bug.cgi?id=207004

Attachment 389266: Patch

https://bugs.webkit.org/attachment.cgi?id=389266&action=review




--- Comment #10 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 389266
  --> https://bugs.webkit.org/attachment.cgi?id=389266
Patch

On the second thought, I still think it shouldn't go in as is. if/else branch
depending on state of ${_target_logical_name}_PRIVATE_LIBRARIES variable may
lead to hidden bugs for targets (or cases, as it tests emptiness instead of
definedness) when variable is empty, while in opposite cases it doesn't check
that ${_target_logical_name}_LIBRARIES} does not contain PUBLIC/PRIVATE
keywords. So we have more variants of behavior with more kinds of possible
errors.