[webkit-reviews] review granted: [Bug 207017] Can still get stuck after swipe backwards with a slow server, even after r254552 : [Attachment 389287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 30 14:10:08 PST 2020


Chris Dumez <cdumez at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 207017: Can still get stuck after swipe backwards with a slow server, even
after r254552
https://bugs.webkit.org/show_bug.cgi?id=207017

Attachment 389287: Patch

https://bugs.webkit.org/attachment.cgi?id=389287&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 389287
  --> https://bugs.webkit.org/attachment.cgi?id=389287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389287&action=review

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:391
> +void ProvisionalPageProxy::navigationGestureDidEnd()

Can we call this something like: unfreezeLayerTreeDueToSwipeAnimation() ? Given
that you're only calling this when the m_isLayerTreeFrozenDueToSwipeAnimation
flag is set on the WebPageProxy.


More information about the webkit-reviews mailing list