[webkit-reviews] review granted: [Bug 206607] WebKitTestRunner: use ad hoc signing for internal Production builds : [Attachment 389282] Another speculative test fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 206607: WebKitTestRunner: use ad hoc signing for internal Production builds
https://bugs.webkit.org/show_bug.cgi?id=206607

Attachment 389282: Another speculative test fix

https://bugs.webkit.org/attachment.cgi?id=389282&action=review




--- Comment #24 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 389282
  --> https://bugs.webkit.org/attachment.cgi?id=389282
Another speculative test fix

View in context: https://bugs.webkit.org/attachment.cgi?id=389282&action=review

> Source/WebKit/ChangeLog:3
> +	   Unreviewed, another speculative test fix after r255041

This says "unreviewed", but the patch is marked for review. Looks reasonable,
rs=me with one question.

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:359
> +	   (id)kSecAttrAccessible: (id)kSecAttrAccessibleAfterFirstUnlock,

Why not kSecAttrAccessibleAlways? I don't think that there is a practical
difference, but "always" is what we want for testing, so it seems better to
request that explicitly.