[webkit-reviews] review denied: [Bug 206982] REGRESSION(r254389): High Sierra build is broken : [Attachment 389223] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 29 21:02:28 PST 2020
Alexey Proskuryakov <ap at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 206982: REGRESSION(r254389): High Sierra build is broken
https://bugs.webkit.org/show_bug.cgi?id=206982
Attachment 389223: Patch
https://bugs.webkit.org/attachment.cgi?id=389223&action=review
--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 389223
--> https://bugs.webkit.org/attachment.cgi?id=389223
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=389223&action=review
r- for changing Mojave code path. Please also see my comment in Radar.
> Source/WTF/wtf/PlatformHave.h:578
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) ||
PLATFORM(IOS_FAMILY)
High Sierra is 10.13
Mojave is 10.14
Catalina is 10.15
More information about the webkit-reviews
mailing list