[webkit-reviews] review granted: [Bug 206911] Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name : [Attachment 389197] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 29 16:58:53 PST 2020


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 206911: Web Inspector: safari app extension isolated worlds and injected
files use the extension's identifier instead of its name
https://bugs.webkit.org/show_bug.cgi?id=206911

Attachment 389197: Patch

https://bugs.webkit.org/attachment.cgi?id=389197&action=review




--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 389197
  --> https://bugs.webkit.org/attachment.cgi?id=389197
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389197&action=review

r=me! (with EWS)

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:-241
> -/*! @abstract Called when a Web Inspector instance is attached to this
WKWebView. This is not called in the case of remote inspection.

Please save my comment :)


More information about the webkit-reviews mailing list