[webkit-reviews] review granted: [Bug 206932] run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504) : [Attachment 389193] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 206932: run-safari / run-webkit-tests --ios-simulator not working with
XCode 13.3.1 (11C504)
https://bugs.webkit.org/show_bug.cgi?id=206932

Attachment 389193: Patch

https://bugs.webkit.org/attachment.cgi?id=389193&action=review




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 389193
  --> https://bugs.webkit.org/attachment.cgi?id=389193
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389193&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:206
> +	   # Return the available runtime closest to specified runtime

I don't think that "closest" explains it well. We should either call it "best
match", or actually explain what the code is trying to achieve. Also, please
add a period at the end of the sentence.