[webkit-reviews] review granted: [Bug 206966] Don't include CCallHelpers.h in B3Procedure.h : [Attachment 389186] fix style nit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 29 15:04:15 PST 2020


Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 206966: Don't include CCallHelpers.h in B3Procedure.h
https://bugs.webkit.org/show_bug.cgi?id=206966

Attachment 389186: fix style nit

https://bugs.webkit.org/attachment.cgi?id=389186&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 389186
  --> https://bugs.webkit.org/attachment.cgi?id=389186
fix style nit

View in context: https://bugs.webkit.org/attachment.cgi?id=389186&action=review

> Source/JavaScriptCore/b3/testb3_6.cpp:2176
> +    CodeLocationLabel<B3CompilationPtrTag> labelOne =
linkBuffer.locationOf<B3CompilationPtrTag>(proc.code().entrypointLabel(0));

should we also make AirCode not use Label directly?


More information about the webkit-reviews mailing list