[webkit-reviews] review granted: [Bug 206919] macCatalyst: Right clicking on a link follows it immediately : [Attachment 389106] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 28 22:01:40 PST 2020


Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 206919: macCatalyst: Right clicking on a link follows it immediately
https://bugs.webkit.org/show_bug.cgi?id=206919

Attachment 389106: Patch

https://bugs.webkit.org/attachment.cgi?id=389106&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 389106
  --> https://bugs.webkit.org/attachment.cgi?id=389106
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389106&action=review

> Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:177
> +    _pressedButtonMask = WTF::nullopt;

Should we clear this out in -touchesCancelled:withEvent: as well?


More information about the webkit-reviews mailing list