[webkit-reviews] review granted: [Bug 206906] Limit access to 'com.apple.SecurityService' and 'com.apple.ocspd' to systems that require it : [Attachment 389100] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 206906: Limit access to 'com.apple.SecurityService' and 'com.apple.ocspd'
to systems that require it
https://bugs.webkit.org/show_bug.cgi?id=206906

Attachment 389100: Patch

https://bugs.webkit.org/attachment.cgi?id=389100&action=review




--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 389100
  --> https://bugs.webkit.org/attachment.cgi?id=389100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389100&action=review

> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:621
> +    if (osVersionParts[0].toInt() == 10 && osVersionParts[1].toInt() <= 15)
{

Can you put this into an #if block too, so that it’s easier to remove in the
future?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:674
> +(if (equal? (param "_OS_NEEDS_EME_QUIRK") "YES")

Did you check how this behaves on old OS versions? I vaguely remember that
profile may fail to compile when an undefined param is used.