[webkit-reviews] review denied: [Bug 206906] Limit access to 'com.apple.SecurityService' and 'com.apple.ocspd' to systems that require it : [Attachment 389077] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 206906: Limit access to 'com.apple.SecurityService' and 'com.apple.ocspd'
to systems that require it
https://bugs.webkit.org/show_bug.cgi?id=206906

Attachment 389077: Patch

https://bugs.webkit.org/attachment.cgi?id=389077&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 389077
  --> https://bugs.webkit.org/attachment.cgi?id=389077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389077&action=review

> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:622
> +	   if (osVersionParts.size() < 3 || osVersionParts[2].toInt() <= 3)

The logic looks wrong here. It seems exceeding unlikely that you are getting
the right set of versions here. 

This means that 10.14.3 and 10.15.3 both need the parameter, but .4 updates do
not.

> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:623
> +	       sandboxParameters.addParameter("_OS_NEEDS_EME_QUIRK", "YES");

We control all parameter names, what is the need for the leading underscore?