[webkit-reviews] review denied: [Bug 206783] Web Inspector: Color picker: when zoomed, crosshair is misplaced on clicking : [Attachment 388789] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 206783: Web Inspector: Color picker: when zoomed, crosshair is misplaced on
clicking
https://bugs.webkit.org/show_bug.cgi?id=206783

Attachment 388789: Patch

https://bugs.webkit.org/attachment.cgi?id=388789&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 388789
  --> https://bugs.webkit.org/attachment.cgi?id=388789
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388789&action=review

r-, as this breaks the bezier editor in RTL

> Source/WebInspectorUI/UserInterface/Models/Geometry.js:44
> +	   return new WI.Point(

Style: we don't do this kind of multi-line function calling, so please collapse
it into a single line
```
    return new WI.Point(event.pageX - rect.x, event.pageY - rect.y);
```

> Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:191
> +	   let point = {

NIT: `point` isn't used anywhere else, so you could just inline it:
```
    this._setCrosshairPosition({
	x: event.pageX - rect.x,
	y: event.pageY - rect.y,
    });
```