[webkit-reviews] review granted: [Bug 206913] TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION) : [Attachment 389082] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 28 16:06:16 PST 2020
Chris Dumez <cdumez at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 206913: TestWebKitAPI: Conditionalize device orientation tests on
ENABLE(DEVICE_ORIENTATION)
https://bugs.webkit.org/show_bug.cgi?id=206913
Attachment 389082: Patch
https://bugs.webkit.org/attachment.cgi?id=389082&action=review
--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 389082
--> https://bugs.webkit.org/attachment.cgi?id=389082
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=389082&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:28
> +#if ENABLE(DEVICE_ORIENTATION) && PLATFORM(IOS_FAMILY)
Please update this comment at the end of the file as well:
#endif // PLATFORM(IOS_FAMILY)
More information about the webkit-reviews
mailing list