[webkit-reviews] review granted: [Bug 206863] macCatalyst: Triple clicking to select a sentence results in an empty selection : [Attachment 389072] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 206863: macCatalyst: Triple clicking to select a sentence results in an
empty selection
https://bugs.webkit.org/show_bug.cgi?id=206863

Attachment 389072: Patch

https://bugs.webkit.org/attachment.cgi?id=389072&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 389072
  --> https://bugs.webkit.org/attachment.cgi?id=389072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389072&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:2492
> +void WebPageProxy::doAfterProcessingAllPendingMouseEvents(WTF::Function<void
(void)>&& action)

Nit - I think we usually write this WTF::Function<void()>&& (i.e. no second
void)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:28
> +#if PLATFORM(MACCATALYST)

Is it possible to adjust this such that we'll run these tests in automation?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:131
> +    [gesture _hoverEntered:touchSet.get() withEvent:event.get()];
> +    [contentView _mouseGestureRecognizerChanged:gesture];
> +    [touch setTapCount:1];
> +    [event _setButtonMask:UIEventButtonMaskSecondary];
> +    [gesture touchesBegan:touchSet.get() withEvent:event.get()];
> +    [contentView _mouseGestureRecognizerChanged:gesture];
> +    [gesture touchesEnded:touchSet.get() withEvent:event.get()];
> +    [contentView _mouseGestureRecognizerChanged:gesture];

Very exciting!

Not for this patch, but this seems good to one day unify under the existing
macOS click simulation helpers in TestWKWebView.