[webkit-reviews] review granted: [Bug 206858] Reset the application bundle identifier between test runs : [Attachment 389048] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 206858: Reset the application bundle identifier between test runs
https://bugs.webkit.org/show_bug.cgi?id=206858

Attachment 389048: Patch

https://bugs.webkit.org/attachment.cgi?id=389048&action=review




--- Comment #10 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 389048
  --> https://bugs.webkit.org/attachment.cgi?id=389048
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389048&action=review

Looks good! Should we also delete the code which exits, and the associated
flag? R=me.

> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:72
> +    applicationBundleIdentifierOverride() = String();

emptyString()?