[webkit-reviews] review granted: [Bug 206681] REGRESSION: [iOS] http/wpt/cache-storage/quota-third-party.https.html is flaky failing. : [Attachment 389012] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted katherine_cheney at apple.com's
request for review:
Bug 206681: REGRESSION: [iOS]
http/wpt/cache-storage/quota-third-party.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206681

Attachment 389012: Patch

https://bugs.webkit.org/attachment.cgi?id=389012&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 389012
  --> https://bugs.webkit.org/attachment.cgi?id=389012
Patch

r=me but I think we should consider turning off the behavior that removes
"websitedata store" for iframes.

View in context: https://bugs.webkit.org/attachment.cgi?id=389012&action=review

> LayoutTests/ChangeLog:9
> +	   the origin's cache was deleted before the test finished.

I wonder whether we should turn off this behavior by default for tests and
enable it for specific tests that actually require that behavior.
My fear is that other tests might end up have similar issues and we will have
difficulties understanding why, or fixing them if WPT.

> LayoutTests/http/wpt/cache-storage/quota-third-party.https.html:13
> +    testRunner.setStatisticsHasHadUserInteraction("https://127.0.0.1:9443",
true, start());

Should it be start instead of start()?
Or can we not pass any function at all and not have any start function?