[webkit-reviews] review granted: [Bug 206861] [LFC][IFC] Decouple Display::LineBox and Layout::LineBox : [Attachment 388991] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 206861: [LFC][IFC] Decouple Display::LineBox and Layout::LineBox
https://bugs.webkit.org/show_bug.cgi?id=206861

Attachment 388991: Patch

https://bugs.webkit.org/attachment.cgi?id=388991&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388991
  --> https://bugs.webkit.org/attachment.cgi?id=388991
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388991&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:544
> +    inlineContent.lineBoxes.append(Display::LineBox { lineBox.logicalRect(),
lineBox.scrollableOverflow(), lineInkOverflow, { baseline.ascent(),
baseline.descent() }, lineBox.baselineOffset(), lineBox.isConsideredEmpty() });

Could have some sort of helper for the conversion.

Type name Display::LineBox is probably not needed.

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:36
> +namespace Layout {
> +
> +class LineBox {

Could this be like LineBoxBuilder or something?