[webkit-reviews] review granted: [Bug 206107] Nullptr crash in WebCore::findPlaceForCounter with display: contents sibling : [Attachment 388953] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Jack <shihchieh_lee at apple.com>'s
request for review:
Bug 206107: Nullptr crash in WebCore::findPlaceForCounter with display:
contents sibling
https://bugs.webkit.org/show_bug.cgi?id=206107

Attachment 388953: Patch

https://bugs.webkit.org/attachment.cgi?id=388953&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388953
  --> https://bugs.webkit.org/attachment.cgi?id=388953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388953&action=review

> Source/WebCore/rendering/RenderCounter.cpp:80
> +    Element* previous =
ElementTraversal::pseudoAwarePreviousSibling(*element);

Could be auto*

> Source/WebCore/rendering/RenderCounter.cpp:87
> +    RenderElement* renderer = element->renderer();

auto*

> Source/WebCore/rendering/RenderCounter.cpp:90
> +    if (renderer && renderer->isPseudoElement()) {
> +	   return renderer->generatingElement();
>      }

WebKit coding style doesn't use { } around single line blocks.

> Source/WebCore/rendering/RenderCounter.cpp:104
> +    Element* previous = previousSiblingOrParentElement(renderer.element());

auto*