[webkit-reviews] review denied: [Bug 206099] Deploy Ref and RefPtr in DOMWindow::scroll* functions : [Attachment 388966] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Pinki Gyanchandani
<pgyanchandani at apple.com>'s request for review:
Bug 206099: Deploy Ref and RefPtr in DOMWindow::scroll* functions
https://bugs.webkit.org/show_bug.cgi?id=206099

Attachment 388966: Patch

https://bugs.webkit.org/attachment.cgi?id=388966&action=review




--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 388966
  --> https://bugs.webkit.org/attachment.cgi?id=388966
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388966&action=review

r- due to the following issues.

> Source/WebCore/ChangeLog:3
> +	   Deploy Ref and RefPtr in DOMWindow::scroll* functions

The title of this bug doesn’t match your patch at all. Please fix it.

> Source/WebCore/ChangeLog:8
> +	   Added Null pointer check for frame in scrollBy function before
usage.

Nit: null pointer check, not Null pointer check.

> Source/WebCore/page/DOMWindow.cpp:1690
> +    FrameView* view = frame->view();

We should store FrameView in RefPtr. Use auto & makeRefPtr.

>
LayoutTests/platform/mac/fast/dom/Window/window-scroll-ignore-null-frame-expect
ed.txt:1
> +layer at (0,0) size 800x600

Please call dumpAsText in the test and add a platform agnostic result.