[webkit-reviews] review granted: [Bug 206856] Python 3: Update windows scripts and uses of is constant : [Attachment 388946] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 206856: Python 3: Update windows scripts and uses of is constant
https://bugs.webkit.org/show_bug.cgi?id=206856

Attachment 388946: Patch

https://bugs.webkit.org/attachment.cgi?id=388946&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 388946
  --> https://bugs.webkit.org/attachment.cgi?id=388946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388946&action=review

> Tools/Scripts/download-github-release.py:-30
> -import urllib2

We clearly don't have test coverage here. Do you know who uses this script?

> Tools/Scripts/webkitpy/common/system/profiler.py:175
> +	   if exit_code != 0:

What sort of linter are you running to find these? Is that a Python 3.8 thing?

If so, would you mind run 'test-webkitpy-python3' and fixing everything it
flags in a separate patch?