[webkit-reviews] review granted: [Bug 206849] Add WKWebView SPI equivalent of WKView.shouldClipToVisibleRect : [Attachment 388934] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206849: Add WKWebView SPI equivalent of WKView.shouldClipToVisibleRect
https://bugs.webkit.org/show_bug.cgi?id=206849

Attachment 388934: Patch

https://bugs.webkit.org/attachment.cgi?id=388934&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 388934
  --> https://bugs.webkit.org/attachment.cgi?id=388934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388934&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:518
> + at property (nonatomic, readwrite, setter=_setClipsToVisibleRect:) BOOL
_clipsToVisibleRect WK_API_AVAILABLE(macos(WK_MAC_TBA));

Please add some explanatory comment in header doc style. I would suggest:

_clipsToVisibleRect: When YES, the view will use its -visibleRect when
determining which areas of the WKWebView to draw. This may improve performance
for large WKWebViews which are mostly clipped out by enclosing views.

Should we make this available for iOS too?