[webkit-reviews] review granted: [Bug 206807] [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests : [Attachment 388801] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 206807: [ews] Status bubble hover over message in case of success should
indicate whether it built the patch or run tests
https://bugs.webkit.org/show_bug.cgi?id=206807

Attachment 388801: Patch

https://bugs.webkit.org/attachment.cgi?id=388801&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 388801
  --> https://bugs.webkit.org/attachment.cgi?id=388801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388801&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:125
> +		       bubble['details_message'] = 'Pass'

Not convinced this is the best UI for Perl and Python tests, but it's
definitely an improvement for webkit queues.