[webkit-reviews] review granted: [Bug 206813] [LFC][IFC] Display::LineBox has one type of geometry only. : [Attachment 388819] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 206813: [LFC][IFC] Display::LineBox has one type of geometry only.
https://bugs.webkit.org/show_bug.cgi?id=206813

Attachment 388819: Patch

https://bugs.webkit.org/attachment.cgi?id=388819&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388819
  --> https://bugs.webkit.org/attachment.cgi?id=388819
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388819&action=review

> Source/WebCore/ChangeLog:8
> +	   It can either represent a logical line box (during layout) or a
physical one (during paint/hittest).

This doesn't feel right. Shouldn't we have separate classes for these cases?