[webkit-reviews] review granted: [Bug 206819] [Web Animations] Update all DocumentTimeline objects when updating animations : [Attachment 388835] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 27 02:41:32 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 206819: [Web Animations] Update all DocumentTimeline objects when updating
animations
https://bugs.webkit.org/show_bug.cgi?id=206819

Attachment 388835: Patch

https://bugs.webkit.org/attachment.cgi?id=388835&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388835
  --> https://bugs.webkit.org/attachment.cgi?id=388835
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388835&action=review

> Source/WebCore/dom/Document.h:2042
> +    Vector<WeakPtr<DocumentTimeline>> m_timelines;

You might want to use WeakHashSet instead if ordering doesn't matter.


More information about the webkit-reviews mailing list