[webkit-reviews] review granted: [Bug 206816] Make getVTablePointer() an inline function to be compliant with WebKit style guidelines. : [Attachment 388823] proposed patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 206816: Make getVTablePointer() an inline function to be compliant with
WebKit style guidelines.
https://bugs.webkit.org/show_bug.cgi?id=206816

Attachment 388823: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=388823&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 388823
  --> https://bugs.webkit.org/attachment.cgi?id=388823
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=388823&action=review

> Source/WTF/wtf/PointerPreparations.h:36
>  #if __has_builtin(__builtin_get_vtable_pointer)

Why is this after the CPU(ARM64E) check. Wouldn't we want to use the builtin if
it exists, regardless of what the CPU is?