[webkit-reviews] review granted: [Bug 206705] Crash in RenderElement::selectionPseudoStyle with detail element set to display: contents : [Attachment 388598] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Doug Kelly <dougk at apple.com>'s
request for review:
Bug 206705: Crash in RenderElement::selectionPseudoStyle with detail element
set to display: contents
https://bugs.webkit.org/show_bug.cgi?id=206705

Attachment 388598: Patch

https://bugs.webkit.org/attachment.cgi?id=388598&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 388598
  --> https://bugs.webkit.org/attachment.cgi?id=388598
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388598&action=review

r=me but I have to admit the logic of the change is not obvious to me

> Source/WebCore/rendering/RenderElement.cpp:1419
> +	       while (currentElement && currentElement->hasDisplayContents())
> +		   currentElement = currentElement->parentElement();

It’s not obvious *why* this is the right thing to do. So we need a comment. Why
are we skipping over any element that "has display contents"?