[webkit-reviews] review requested: [Bug 206791] Move singleton Intl string locales out of JSGlobalObject. : [Attachment 388755] proposed patch.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 206791: Move singleton Intl string locales out of JSGlobalObject.
https://bugs.webkit.org/show_bug.cgi?id=206791

Attachment 388755: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=388755&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 388755
  --> https://bugs.webkit.org/attachment.cgi?id=388755
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=388755&action=review

> Source/JavaScriptCore/runtime/IntlPluralRules.cpp:124
> -    const HashSet<String> availableLocales =
globalObject->intlNumberFormatAvailableLocales();
> +    const HashSet<String>& availableLocales =
intlNumberFormatAvailableLocales();

Andy, can you confirm that it is intentional to use
intlNumberFormatAvailableLocales() instead of intlPluralRulesAvailableLocales()
here?  I noticed that intlPluralRulesAvailableLocales() is called anywhere,
which may me suspicious of this code.  Thought you might know better what is
correct.