[webkit-reviews] review granted: [Bug 206775] Update EditorState from WebProcess when requesting context menu : [Attachment 388734] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 206775: Update EditorState from WebProcess when requesting context menu
https://bugs.webkit.org/show_bug.cgi?id=206775

Attachment 388734: Patch

https://bugs.webkit.org/attachment.cgi?id=388734&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 388734
  --> https://bugs.webkit.org/attachment.cgi?id=388734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388734&action=review

> Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:-72
> -   
m_page->send(Messages::WebPageProxy::ShowContextMenu(contextMenuContextData,
UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get(
))));

This seems okay, but we should also consider just calling
flushPendingEditorStateUpdate() sending WebPageProxy::ShowContextMenu.

This would have the advantage of avoiding editor state computation in the state
where nothing changed (so m_hasPendingEditorStateUpdate is false).