[webkit-reviews] review granted: [Bug 206703] Fix OpenSource iphoneos arm64e build : [Attachment 388713] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 24 15:29:46 PST 2020
Yusuke Suzuki <ysuzuki at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 206703: Fix OpenSource iphoneos arm64e build
https://bugs.webkit.org/show_bug.cgi?id=206703
Attachment 388713: Patch
https://bugs.webkit.org/attachment.cgi?id=388713&action=review
--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 388713
--> https://bugs.webkit.org/attachment.cgi?id=388713
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=388713&action=review
r=me with nit.
> Source/JavaScriptCore/runtime/MachineContext.h:60
> +#if OS(DARWIN) && !USE(PLATFORM_REGISTERS_WITH_PROFILE) && (CPU(ARM_THUMB2)
|| CPU(ARM) || CPU(ARM64))
> +#define USE_DARWIN_REGISTER_MACROS 1
> +#endif
Let's put this in wtf/PlatformUse.h
More information about the webkit-reviews
mailing list