[webkit-reviews] review granted: [Bug 206601] Delete the ITP storage file that is not being used (plist or database file) when switching to a new storage type : [Attachment 388450] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted
katherine_cheney at apple.com's request for review:
Bug 206601: Delete the ITP storage file that is not being used (plist or
database file) when switching to a new storage type
https://bugs.webkit.org/show_bug.cgi?id=206601

Attachment 388450: Patch

https://bugs.webkit.org/attachment.cgi?id=388450&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 388450
  --> https://bugs.webkit.org/attachment.cgi?id=388450
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388450&action=review

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:167
> +	       auto persistentStorageFilePath =
FileSystem::pathByAppendingComponent(resourceLoadStatisticsDirectory,
"full_browsing_session_resourceLog.plist");

Let's name this variable "legacyPlistFilePath" to indicate that it is something
we are migrating from and intent to remove support for in the future.