[webkit-reviews] review granted: [Bug 206582] [Cocoa] Use AVAssetWriterDelegate to implement MediaRecorder : [Attachment 388661] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 206582: [Cocoa] Use AVAssetWriterDelegate to implement MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=206582

Attachment 388661: Patch

https://bugs.webkit.org/attachment.cgi?id=388661&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 388661
  --> https://bugs.webkit.org/attachment.cgi?id=388661
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388661&action=review

>
Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:124
> +    const void *cookie =
CMAudioFormatDescriptionGetMagicCookie(formatDescription, &cookieSize);

This should be added to CoreMediaSoftLink.

>
Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:273
> +    if (auto error = CMBlockBufferReplaceDataBytes(data, buffer.get(), 0,
dataSize)) {

Ditto

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
281
> +    if (![m_videoAssetWriterInput isReadyForMoreMediaData])
> +	   [m_writer flush];

Will the AssetWriter always be ready for more media data after flushing the
writer?