[webkit-reviews] review granted: [Bug 206688] [Web Animations] Support multiple CSS Animations with the same name in animation-name : [Attachment 388660] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 206688: [Web Animations] Support multiple CSS Animations with the same name
in animation-name
https://bugs.webkit.org/show_bug.cgi?id=206688

Attachment 388660: Patch

https://bugs.webkit.org/attachment.cgi?id=388660&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 388660
  --> https://bugs.webkit.org/attachment.cgi?id=388660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388660&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:224
> +    for (size_t i = 0; i < cssAnimationList->size(); ++i) {
> +	   if (cssAnimationList->animation(i) == backingAnimation) {
> +	       auto newAnimationList = cssAnimationList->copy();
> +	       newAnimationList->remove(i);
> +	      
keyframeEffectStack.setCSSAnimationList(WTFMove(newAnimationList));
> +	       return;
> +	   }
> +    }

Why don't you add a remove() to CSSAnimationList that accepts an Animation as a
parameter? Is there a reason you don't want to edit the list in place?