[webkit-reviews] review granted: [Bug 206744] [LFC][Painting] Add Display::Run cleanup to TextPainter::clearGlyphDisplayLists : [Attachment 388687] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 206744: [LFC][Painting] Add Display::Run cleanup to
TextPainter::clearGlyphDisplayLists
https://bugs.webkit.org/show_bug.cgi?id=206744

Attachment 388687: Patch

https://bugs.webkit.org/attachment.cgi?id=388687&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388687
  --> https://bugs.webkit.org/attachment.cgi?id=388687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388687&action=review

> Source/WebCore/rendering/TextPainter.cpp:219
> +#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
> +    GlyphDisplayListCache<Display::Run>::singleton().clear();
> +#endif

Could have runtime check too to avoid unnecessary construction of the
singleton.