[webkit-reviews] review granted: [Bug 206217] Substitute data lost after reload : [Attachment 388676] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 206217: Substitute data lost after reload
https://bugs.webkit.org/show_bug.cgi?id=206217

Attachment 388676: Patch

https://bugs.webkit.org/attachment.cgi?id=388676&action=review




--- Comment #8 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 388676
  --> https://bugs.webkit.org/attachment.cgi?id=388676
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388676&action=review

Nice tests! (As usual.)

I notice the red EWS are all failing on preexisting/unrelated contentfiltering
layout test failures. Looks like the Mac test results are just in bad state
ATM.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:239
> +    webkit_web_view_set_custom_charset(test->m_webView, "utf8");

I guess you're testing the reload that occurs when you change the charset?
That's far from obvious, so it could use a comment.