[webkit-reviews] review granted: [Bug 206611] [ARMv7][JIT] Implement checkpoint support : [Attachment 388671] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 206611: [ARMv7][JIT] Implement checkpoint support
https://bugs.webkit.org/show_bug.cgi?id=206611

Attachment 388671: Patch

https://bugs.webkit.org/attachment.cgi?id=388671&action=review




--- Comment #11 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 388671
  --> https://bugs.webkit.org/attachment.cgi?id=388671
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388671&action=review

r=me with nits.

> Source/JavaScriptCore/dfg/DFGOSREntry.cpp:310
> +	   if (CallFrame::headerSizeInRegisters == 5)

Let's use

if constexpr (CallFrame::CallerFrameAndPC::sizeInRegisters == 2) {
} else {
}

Since CallerFrameAndPC is the problematic part.

> Source/JavaScriptCore/jit/GPRInfo.h:536
> +    static constexpr unsigned numberOfRegisters = 9;

Nice.