[webkit-reviews] review granted: [Bug 206720] Break the dependency between jsc and DerivedSources : [Attachment 388627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 20:03:59 PST 2020


Mark Lam <mark.lam at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 206720: Break the dependency between jsc and DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=206720

Attachment 388627: Patch

https://bugs.webkit.org/attachment.cgi?id=388627&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 388627
  --> https://bugs.webkit.org/attachment.cgi?id=388627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388627&action=review

> Source/JavaScriptCore/ChangeLog:9
> +	   Now that BytecodeStructs.h is no longer included in
CommonSlowPaths.cpp (see https://bugs.webkit.org/show_bug.cgi?id=206566), I'm
trying to break the dependency, to recover from this compile time regression.

I think you mean CommonSlowPaths.h here.


More information about the webkit-reviews mailing list