[webkit-reviews] review granted: [Bug 206607] WebKitTestRunner: use ad hoc signing for internal Production builds : [Attachment 388597] Patch V5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 23 15:51:59 PST 2020
Jonathan Bedard <jbedard at apple.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 206607: WebKitTestRunner: use ad hoc signing for internal Production builds
https://bugs.webkit.org/show_bug.cgi?id=206607
Attachment 388597: Patch V5
https://bugs.webkit.org/attachment.cgi?id=388597&action=review
--- Comment #17 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 388597
--> https://bugs.webkit.org/attachment.cgi?id=388597
Patch V5
Not a super great way to test this one, so we probably need to actually tests
this with production builders.
Keith and Jiewen talked about this, and think it will fix our problems.
I'm going to r+ so we can test this, Jiewen said he's going to watch the bots
to rollout if everything catches on fire.
More information about the webkit-reviews
mailing list