[webkit-reviews] review denied: [Bug 206703] Fix OpenSource iphoneos arm64e build : [Attachment 388599] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied  review:
Bug 206703: Fix OpenSource iphoneos arm64e build
https://bugs.webkit.org/show_bug.cgi?id=206703

Attachment 388599: Patch

https://bugs.webkit.org/attachment.cgi?id=388599&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 388599
  --> https://bugs.webkit.org/attachment.cgi?id=388599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388599&action=review

> Source/JavaScriptCore/runtime/MachineContext.h:98
> +    return reinterpret_cast<void*&>(regs.__opaque_sp);

Actually, Yusuke is right.  Can you use the appropriate macros / setter /
getters for this instead of accessing __opaque_sp directly?

> Source/JavaScriptCore/runtime/MachineContext.h:404
> +    return reinterpret_cast<void*&>(regs.__opaque_pc);

Ditto.