[webkit-reviews] review granted: [Bug 206610] Crash in RenderBlockFlow::adjustLinePositionForPagination() with complex line without root box : [Attachment 388472] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Doug Kelly <dougk at apple.com>'s request for
review:
Bug 206610: Crash in RenderBlockFlow::adjustLinePositionForPagination() with
complex line without root box
https://bugs.webkit.org/show_bug.cgi?id=206610

Attachment 388472: Patch

https://bugs.webkit.org/attachment.cgi?id=388472&action=review




--- Comment #6 from zalan <zalan at apple.com> ---
Comment on attachment 388472
  --> https://bugs.webkit.org/attachment.cgi?id=388472
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388472&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:1813
> +	       if (!firstRootBox)
> +		   return;

I think what we want here is to ignore the firstRootBox when it is nullptr but
still call setPaginationStrut() (not that it matters since this is such an edge
case)
(and please use the attached test reduction)