[webkit-reviews] review granted: [Bug 206664] [Web Animations] Make AnimationList ref-counted : [Attachment 388558] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 23 10:46:31 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 206664: [Web Animations] Make AnimationList ref-counted
https://bugs.webkit.org/show_bug.cgi?id=206664

Attachment 388558: Patch

https://bugs.webkit.org/attachment.cgi?id=388558&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 388558
  --> https://bugs.webkit.org/attachment.cgi?id=388558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388558&action=review

> Source/WebCore/platform/animation/AnimationList.h:38
> +    static Ref<AnimationList> create(const AnimationList& other) { return
adoptRef(*new AnimationList(other)); }

copy() member function would be nicer.


More information about the webkit-reviews mailing list