[webkit-reviews] review denied: [Bug 206664] [Web Animations] Make AnimationList ref-counted : [Attachment 388549] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 206664: [Web Animations] Make AnimationList ref-counted
https://bugs.webkit.org/show_bug.cgi?id=206664

Attachment 388549: Patch

https://bugs.webkit.org/attachment.cgi?id=388549&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 388549
  --> https://bugs.webkit.org/attachment.cgi?id=388549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388549&action=review

> Source/WebCore/platform/animation/AnimationList.cpp:36
> +AnimationList::AnimationList()

You can say  = default

> Source/WebCore/platform/animation/AnimationList.h:34
> +class AnimationList : public RefCounted<AnimationList> {

You still want WTF_MAKE_FAST_ALLOCATED or one of its variants.

> Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:152
> -    , animations(o.animations ? makeUnique<AnimationList>(*o.animations) :
nullptr)
> -    , transitions(o.transitions ? makeUnique<AnimationList>(*o.transitions)
: nullptr)
> +    , animations(o.animations)
> +    , transitions(o.transitions)

This no longer copies