[webkit-reviews] review granted: [Bug 206637] `FALLTHROUGH` macro isn't properly defined when building Objective-C files using Clang : [Attachment 388506] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Conrad Shultz
<conrad_shultz at apple.com>'s request for review:
Bug 206637: `FALLTHROUGH` macro isn't properly defined when building
Objective-C files using Clang
https://bugs.webkit.org/show_bug.cgi?id=206637

Attachment 388506: Patch

https://bugs.webkit.org/attachment.cgi?id=388506&action=review




--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 388506
  --> https://bugs.webkit.org/attachment.cgi?id=388506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388506&action=review

>>> Source/WTF/wtf/Compiler.h:207
>>> +#if COMPILER(GCC) || (COMPILER(CLANG) && __has_attribute(fallthrough))
>> 
>> Why doesn’t the section above with __has_cpp_attribute work? I believe
that’s what’s supposed to cover this.
> 
> Oh, non-C++, I see

Since all the versions of CLANG we compile with have this support, I suggest
just writing:

    #if COMPILE(GCC_COMPATIBLE)