[webkit-reviews] review granted: [Bug 206619] [JSC] Bits from Operand should fit in bits reserved in AbstractHeap's Payload : [Attachment 388475] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 206619: [JSC] Bits from Operand should fit in bits reserved in
AbstractHeap's Payload
https://bugs.webkit.org/show_bug.cgi?id=206619

Attachment 388475: Patch

https://bugs.webkit.org/attachment.cgi?id=388475&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 388475
  --> https://bugs.webkit.org/attachment.cgi?id=388475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388475&action=review

r=me with suggestion.

> Source/JavaScriptCore/bytecode/Operands.h:41
> +enum class OperandKind : uint32_t { Argument, Local, Tmp }; // Keep
bit-width in sync with Operand::operandKindBits' definition.

Nit You can add a `LastOperandKind = Tmp` then compute kindBits from that via
getMSBSet.